allow definition of pub struct via mock_trait #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Yeah, it's a shame that there is currently no 0-or-1 operator in macro definitions. That would remove the duplicate code. I've added an issue to remove this duplicate when the relevant changes have been pushed to stable Rust. The issue is here: |
|
I'll publish a new version of the |
|
Published version 0.1.4 to Cargo, which should contain this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows you to define mock structs with
pubvisibility, which is nice if you want to centrally define a mock struct to be reused in many tests.It looks like this:
Sadly the implementation for this involves a lot of duplicate code, but accoring to rust-lang/rust#18317 (comment) and other things I've found, there doesn't seem to be another way to do that.